feat(landing): add open-source footer - #555
Open
huyanxius wants to merge 3 commits into
Open
Conversation
The public landing page ended without project or contribution links. Add a restrained footer and a desktop marketing-header GitHub entry. Visitors can reach the repository, issues, and contributor history.
The restored footer needs protection against missing or invented public links. Scope landing assertions to their navigation regions and cover footer semantics. The test now guards repository, issue, and contributor destinations.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Frontend CI enforces the repository oxfmt output. Apply the formatter to the scoped landing assertion. The frontend formatting check can proceed past the changed test.
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
审阅了本 PR 的完整固定提交范围，重点检查了宣传页页脚、产品锚点、GitHub 外链、桌面端顶栏入口，以及移动端/已登录状态下的入口行为。新增链接的目标与现有页面契约一致，页脚锚点均有对应目标，外链属性和语义结构也没有发现会造成用户可见回归的问题。
验证结果：npm test -- src/pages/landing/index.test.tsx（5/5）、npm run typecheck、npm run lint 和 git diff --check 17b25a723410244d9f0a68209d3c946ca0698b56...2dadf87cc69591cf6d27c56da8d3a4418275a5ed 均通过。
Collaborator
Author
|
agent截图截错了，应该是这张： |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为 Windup 公开 Landing 页恢复开源项目页脚，并在桌面端宣传页顶栏补充 GitHub 入口，让访客能直接找到源码、问题反馈和贡献记录。
Why
Landing 页此前以收尾插画结束，没有项目来源与参与入口。这让开源属性和维护路径在公开页面上不可见，也使此前完成但未提交的页脚设计被遗漏。
Changes
Implementation
contentinfo与独立导航区，移动端单列、桌面端分栏。target="_blank"与rel="noreferrer"，并保留键盘焦点样式。Verification
npm run format:check：通过。npm test -- src/pages/landing/index.test.tsx：5/5 通过。npm run typecheck：通过。git diff --check upstream/main...HEAD：通过。http://127.0.0.1:5194/：页脚位于收尾插画之后，桌面布局正常。Screenshots
Desktop
Scope
Related Issues
Closes #554